iwlwifi: avoid allocating memory for region with disabled domain
authorShahar S Matityahu <shahar.s.matityahu@intel.com>
Mon, 8 Apr 2019 13:59:53 +0000 (16:59 +0300)
committerLuca Coelho <luciano.coelho@intel.com>
Mon, 29 Apr 2019 15:42:47 +0000 (18:42 +0300)
In iwl_fw_ini_get_trigger_len the driver allocates space for memory
regions regardless of their domain and in iwl_fw_ini_dump_trigger the
driver aborts trigger collection of disabled domain. This diff causes
unneeded memory allocation and traling zeros in the dump file.

Solve this behavior by enforcing domain checking in
iwl_fw_ini_get_trigger_len

Signed-off-by: Shahar S Matityahu <shahar.s.matityahu@intel.com>
Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
drivers/net/wireless/intel/iwlwifi/fw/dbg.c

index 4ef447480aaf34c6c2728bb2e1dd1394ab096140..62fd346ccb77a83a99113ed464a0f7bfb483169c 100644 (file)
@@ -1751,6 +1751,10 @@ static int iwl_fw_ini_get_trigger_len(struct iwl_fw_runtime *fwrt,
                        continue;
                }
 
+               /* currently the driver supports always on domain only */
+               if (le32_to_cpu(reg->domain) != IWL_FW_INI_DBG_DOMAIN_ALWAYS_ON)
+                       continue;
+
                switch (le32_to_cpu(reg->region_type)) {
                case IWL_FW_INI_REGION_DEVICE_MEMORY:
                case IWL_FW_INI_REGION_PERIPHERY_MAC: