bnxt: fix a condition
authorDan Carpenter <dan.carpenter@oracle.com>
Thu, 7 Jul 2016 08:23:09 +0000 (11:23 +0300)
committerDavid S. Miller <davem@davemloft.net>
Sat, 9 Jul 2016 04:02:08 +0000 (00:02 -0400)
This code generates as static checker warning because htons(ETH_P_IPV6)
is always true.  From the context it looks like the && was intended to
be !=.

Fixes: 94758f8de037 ('bnxt_en: Add GRO logic for BCM5731X chips.')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Michael Chan <michael.chan@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/broadcom/bnxt/bnxt.c

index 70b148a10ec8a6062443d471396f73f64aefdecf..659faa6511c018efafd92db8ff563f979e12246c 100644 (file)
@@ -997,7 +997,7 @@ static struct sk_buff *bnxt_gro_func_5731x(struct bnxt_tpa_info *tpa_info,
                 * correct protocol ID, it must be a loopback packet where
                 * the offsets are off by 4.
                 */
-               if (proto != htons(ETH_P_IP) && proto && htons(ETH_P_IPV6))
+               if (proto != htons(ETH_P_IP) && proto != htons(ETH_P_IPV6))
                        loopback = true;
        }
        if (loopback) {