leds-ss4200: Check pci_enable_device return
authorDave Hansen <dave@sr71.net>
Wed, 14 Oct 2009 16:20:47 +0000 (09:20 -0700)
committerRichard Purdie <rpurdie@linux.intel.com>
Wed, 16 Dec 2009 11:30:09 +0000 (11:30 +0000)
pci_enable_result is defined using the __must_check macro but
leds-ss4200 is not checking the return value.

Signed-off-by: Javier Martinez Canillas <martinez.javier@gmail.com>
Signed-off-by: Dave Hansen <dave@sr71.net>
Signed-off-by: Richard Purdie <rpurdie@linux.intel.com>
drivers/leds/leds-ss4200.c

index 0ec4ec3bc823061592d5e42758b2a5b14b151b15..c7f634727d6794a2f715cdf4a49ea8e28a274718 100644 (file)
@@ -344,10 +344,14 @@ static struct pci_dev *nas_gpio_pci_dev;
 static int __devinit ich7_lpc_probe(struct pci_dev *dev,
                                    const struct pci_device_id *id)
 {
-       int status = 0;
+       int status;
        u32 gc = 0;
 
-       pci_enable_device(dev);
+       status = pci_enable_device(dev);
+       if (status) {
+               dev_err(&dev->dev, "pci_enable_device failed\n");
+               return;
+       }
 
        nas_gpio_pci_dev = dev;
        status = pci_read_config_dword(dev, PMBASE, &g_pm_io_base);