net: aquantia: cleanup err handing in hw_atl_utils_fw_rpc_wait
authorYueHaibing <yuehaibing@huawei.com>
Fri, 16 Nov 2018 10:25:27 +0000 (18:25 +0800)
committerDavid S. Miller <davem@davemloft.net>
Sun, 18 Nov 2018 05:15:04 +0000 (21:15 -0800)
'err' always be 0 in the two places.

Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_utils.c

index 7def1cb8ab9d0a620b58f880d7d6e3f7682c4e89..1af6606a916636fb99a4ef3d4636422b4cfd5858 100644 (file)
@@ -454,8 +454,6 @@ int hw_atl_utils_fw_rpc_wait(struct aq_hw_s *self,
                               (fw.val =
                                aq_hw_read_reg(self, HW_ATL_RPC_STATE_ADR),
                                fw.tid), 1000U, 100U);
-               if (err < 0)
-                       goto err_exit;
 
                if (fw.len == 0xFFFFU) {
                        err = hw_atl_utils_fw_rpc_call(self, sw.len);
@@ -463,8 +461,6 @@ int hw_atl_utils_fw_rpc_wait(struct aq_hw_s *self,
                                goto err_exit;
                }
        } while (sw.tid != fw.tid || 0xFFFFU == fw.len);
-       if (err < 0)
-               goto err_exit;
 
        if (rpc) {
                if (fw.len) {