mpc8xxx: USB: fix: access of ehci struct elements
authorVivek Mahajan <vivek.mahajan@freescale.com>
Fri, 19 Jun 2009 12:26:00 +0000 (17:56 +0530)
committerRemy Bohmer <linux@bohmer.net>
Thu, 9 Jul 2009 19:33:15 +0000 (21:33 +0200)
This patch fixes the access to the 'ehci' struct elements which should
have been taken care off in 4ef01010aa4799c759d75e67007fdd3a38c88c8a
Sorry about that.

Signed-off-by: Vivek Mahajan <vivek.mahajan@freescale.com>
Signed-off-by: Remy Bohmer <linux@bohmer.net>
drivers/usb/host/ehci-fsl.c

index bf148c4e2429e588641739edd6a4518f46260ba6..c674929725230a9bb94b9bbe07a802ea56b7611b 100644 (file)
@@ -41,15 +41,15 @@ int ehci_hcd_init(void)
        struct usb_ehci *ehci;
 
        ehci = (struct usb_ehci *)CONFIG_SYS_MPC8xxx_USB_ADDR;
-       hccr = (struct ehci_hccr *)((uint32_t)ehci->caplength);
+       hccr = (struct ehci_hccr *)((uint32_t)&ehci->caplength);
        hcor = (struct ehci_hcor *)((uint32_t) hccr +
                        HC_LENGTH(ehci_readl(&hccr->cr_capbase)));
 
        /* Set to Host mode */
-       setbits_le32((void *)ehci->usbmode, CM_HOST);
+       setbits_le32(&ehci->usbmode, CM_HOST);
 
-       out_be32((void *)ehci->snoop1, SNOOP_SIZE_2GB);
-       out_be32((void *)ehci->snoop2, 0x80000000 | SNOOP_SIZE_2GB);
+       out_be32(&ehci->snoop1, SNOOP_SIZE_2GB);
+       out_be32(&ehci->snoop2, 0x80000000 | SNOOP_SIZE_2GB);
 
        /* Init phy */
        if (!strcmp(getenv("usb_phy_type"), "utmi"))
@@ -58,13 +58,13 @@ int ehci_hcd_init(void)
                out_le32(&(hcor->or_portsc[0]), PORT_PTS_ULPI);
 
        /* Enable interface. */
-       setbits_be32((void *)ehci->control, USB_EN);
+       setbits_be32(&ehci->control, USB_EN);
 
-       out_be32((void *)ehci->prictrl, 0x0000000c);
-       out_be32((void *)ehci->age_cnt_limit, 0x00000040);
-       out_be32((void *)ehci->sictrl, 0x00000001);
+       out_be32(&ehci->prictrl, 0x0000000c);
+       out_be32(&ehci->age_cnt_limit, 0x00000040);
+       out_be32(&ehci->sictrl, 0x00000001);
 
-       in_le32((void *)ehci->usbmode);
+       in_le32(&ehci->usbmode);
 
        return 0;
 }