drm/i915: Actually emit the await_start
authorChris Wilson <chris@chris-wilson.co.uk>
Thu, 5 Mar 2020 10:42:10 +0000 (10:42 +0000)
committerChris Wilson <chris@chris-wilson.co.uk>
Thu, 5 Mar 2020 14:26:22 +0000 (14:26 +0000)
Fix the inverted test to emit the wait on the end of the previous
request if we /haven't/ already.

Fixes: 6a79d848403d ("drm/i915: Lock signaler timeline while navigating")
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
Cc: <stable@vger.kernel.org> # v5.5+
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20200305104210.2619967-1-chris@chris-wilson.co.uk
drivers/gpu/drm/i915/i915_request.c

index 4bfe68edfc815cc9622c1d6a6580c010601657f5..46dae33c1a201c6825cbaa18a8a35a91b5e909f5 100644 (file)
@@ -882,7 +882,7 @@ i915_request_await_start(struct i915_request *rq, struct i915_request *signal)
                return 0;
 
        err = 0;
-       if (intel_timeline_sync_is_later(i915_request_timeline(rq), fence))
+       if (!intel_timeline_sync_is_later(i915_request_timeline(rq), fence))
                err = i915_sw_fence_await_dma_fence(&rq->submit,
                                                    fence, 0,
                                                    I915_FENCE_GFP);