mdio_bus: fix mdio_register_device when RESET_CONTROLLER is disabled
authorMarek Behún <marek.behun@nic.cz>
Mon, 18 Nov 2019 18:15:05 +0000 (19:15 +0100)
committerDavid S. Miller <davem@davemloft.net>
Tue, 19 Nov 2019 01:59:32 +0000 (17:59 -0800)
When CONFIG_RESET_CONTROLLER is disabled, the
devm_reset_control_get_exclusive function returns -ENOTSUPP. This is not
handled in subsequent check and then the mdio device fails to probe.

When CONFIG_RESET_CONTROLLER is enabled, its code checks in OF for reset
device, and since it is not present, returns -ENOENT. -ENOENT is handled.
Add -ENOTSUPP also.

This happened to me when upgrading kernel on Turris Omnia. You either
have to enable CONFIG_RESET_CONTROLLER or use this patch.

Signed-off-by: Marek Behún <marek.behun@nic.cz>
Fixes: 71dd6c0dff51b ("net: phy: add support for reset-controller")
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Andrew Lunn <andrew@lunn.ch>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/phy/mdio_bus.c

index 35876562e32a02ce8b8afd6a5626caba31619eef..c87cb8c0dac8615fa0a5af78e0af4001c5cb1bc7 100644 (file)
@@ -65,7 +65,8 @@ static int mdiobus_register_reset(struct mdio_device *mdiodev)
                reset = devm_reset_control_get_exclusive(&mdiodev->dev,
                                                         "phy");
        if (IS_ERR(reset)) {
-               if (PTR_ERR(reset) == -ENOENT || PTR_ERR(reset) == -ENOSYS)
+               if (PTR_ERR(reset) == -ENOENT || PTR_ERR(reset) == -ENOSYS ||
+                   PTR_ERR(reset) == -ENOTSUPP)
                        reset = NULL;
                else
                        return PTR_ERR(reset);