qed: Flush slowpath tasklet on stop

Today, driver has a synchronization point while closing
the device which synchronizes its slowpath interrupt line.
However, that's insufficient as that ISR would schedule the
slowpath-tasklet - so even after ISR is over it's possible the
handling of the interrupt has not completed.

By doing a disable/enable on the taskelt we guarantee that all
HW events that should no longer be genereated from that point
onward in the flow are truly behind us.

Signed-off-by: Tomer Tayar <Tomer.Tayar@cavium.com>
Signed-off-by: Yuval Mintz <Yuval.Mintz@cavium.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

diff --git a/drivers/net/ethernet/qlogic/qed/qed_main.c b/drivers/net/ethernet/qlogic/qed/qed_main.c
index f286daa59bbc38fb4a857e7ac2866c577627ab2b..3043dcce125c58b5ed013f00a195ac88b05c7c9f 100644 (file)
--- a/drivers/net/ethernet/qlogic/qed/qed_main.c
+++ b/drivers/net/ethernet/qlogic/qed/qed_main.c
@@ -606,6 +606,18 @@ int qed_slowpath_irq_req(struct qed_hwfn *hwfn)
        return rc;
 }
 
+static void qed_slowpath_tasklet_flush(struct qed_hwfn *p_hwfn)
+{
+       /* Calling the disable function will make sure that any
+        * currently-running function is completed. The following call to the
+        * enable function makes this sequence a flush-like operation.
+        */
+       if (p_hwfn->b_sp_dpc_enabled) {
+               tasklet_disable(p_hwfn->sp_dpc);
+               tasklet_enable(p_hwfn->sp_dpc);
+       }
+}
+
 void qed_slowpath_irq_sync(struct qed_hwfn *p_hwfn)
 {
        struct qed_dev *cdev = p_hwfn->cdev;
@@ -617,6 +629,8 @@ void qed_slowpath_irq_sync(struct qed_hwfn *p_hwfn)
                synchronize_irq(cdev->int_params.msix_table[id].vector);
        else
                synchronize_irq(cdev->pdev->irq);
+
+       qed_slowpath_tasklet_flush(p_hwfn);
 }
 
 static void qed_slowpath_irq_free(struct qed_dev *cdev)