netfilter: xt_hashlimit: alloc hashtable with right size
authorZhizhou Tian <zhizhou.tian@gmail.com>
Fri, 8 Sep 2017 03:00:16 +0000 (11:00 +0800)
committerPablo Neira Ayuso <pablo@netfilter.org>
Fri, 8 Sep 2017 16:55:53 +0000 (18:55 +0200)
struct xt_byteslimit_htable used hlist_head, but memory allocation is
done through sizeof(struct list_head).

Signed-off-by: Zhizhou Tian <zhizhou.tian@gmail.com>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
net/netfilter/xt_hashlimit.c

index 10d48234f5f4c759ff03e2b4d262bbd3619594a1..962ea4a63d9fef692489e446639b894acb81500a 100644 (file)
@@ -279,7 +279,7 @@ static int htable_create(struct net *net, struct hashlimit_cfg3 *cfg,
                size = cfg->size;
        } else {
                size = (totalram_pages << PAGE_SHIFT) / 16384 /
-                      sizeof(struct list_head);
+                      sizeof(struct hlist_head);
                if (totalram_pages > 1024 * 1024 * 1024 / PAGE_SIZE)
                        size = 8192;
                if (size < 16)
@@ -287,7 +287,7 @@ static int htable_create(struct net *net, struct hashlimit_cfg3 *cfg,
        }
        /* FIXME: don't use vmalloc() here or anywhere else -HW */
        hinfo = vmalloc(sizeof(struct xt_hashlimit_htable) +
-                       sizeof(struct list_head) * size);
+                       sizeof(struct hlist_head) * size);
        if (hinfo == NULL)
                return -ENOMEM;
        *out_hinfo = hinfo;