wpa_supplicant.sh: always use parameters from the current section
authorFelix Fietkau <nbd@openwrt.org>
Sun, 16 Dec 2012 13:23:37 +0000 (13:23 +0000)
committerFelix Fietkau <nbd@openwrt.org>
Sun, 16 Dec 2012 13:23:37 +0000 (13:23 +0000)
Using variables from the outer scope unnecessarily complicates the code and
leads to issues.

This patch fixes the bug when having an "adhoc" wifi-iface section before a
"sta" section prevents wpa_supplicant from using the key specified in the
corresponding section as it tries to use the "adhoc" key instead (1 by
default).

Signed-off-by: Paul Fertser <fercerpav@gmail.com>
SVN-Revision: 34716

package/network/services/hostapd/files/wpa_supplicant.sh

index 928243e42509156f6400d88985fe9bd7936a4bdd..127c5a70f511a92a1ce2da6b5859981f4341e266 100644 (file)
@@ -9,13 +9,8 @@ wpa_supplicant_setup_vif() {
        local scan_ssid="1"
        [ -n "$4" ] && freq="frequency=$4"
 
-       # make sure we have the encryption type and the psk
-       [ -n "$enc" ] || {
-               config_get enc "$vif" encryption
-       }
-       [ -n "$key" ] || {
-               config_get key "$vif" key
-       }
+       config_get enc "$vif" encryption
+       config_get key "$vif" key
 
        local net_cfg bridge
        config_get bridge "$vif" bridge