Btrfs: make the cleaner complete early when the fs is going to be umounted
authorMiao Xie <miaox@cn.fujitsu.com>
Tue, 14 May 2013 10:20:41 +0000 (10:20 +0000)
committerJosef Bacik <jbacik@fusionio.com>
Fri, 14 Jun 2013 15:29:33 +0000 (11:29 -0400)
Cc: David Sterba <dsterba@suse.cz>
Signed-off-by: Miao Xie <miaox@cn.fujitsu.com>
Signed-off-by: Josef Bacik <jbacik@fusionio.com>
fs/btrfs/disk-io.c

index 7a54b8e7d124b855aa69387d28874f1f1a46385f..06f2c011db0307444c9be6d59930618b44b829d9 100644 (file)
@@ -1674,12 +1674,14 @@ static void end_workqueue_fn(struct btrfs_work *work)
 }
 
 /*
- * If we remount the fs to be R/O, the cleaner needn't do anything except
- * sleeping. This function is used to check the status of the fs.
+ * If we remount the fs to be R/O or umount the fs, the cleaner needn't do
+ * anything except sleeping. This function is used to check the status of
+ * the fs.
  */
 static inline int need_cleaner_sleep(struct btrfs_root *root)
 {
-       return root->fs_info->sb->s_flags & MS_RDONLY;
+       return (root->fs_info->sb->s_flags & MS_RDONLY ||
+               btrfs_fs_closing(root->fs_info));
 }
 
 static int cleaner_kthread(void *arg)
@@ -1702,8 +1704,8 @@ static int cleaner_kthread(void *arg)
                mutex_unlock(&root->fs_info->cleaner_mutex);
 
                /*
-                * The defragger has dealt with the R/O remount, needn't
-                * do anything special here.
+                * The defragger has dealt with the R/O remount and umount,
+                * needn't do anything special here.
                 */
                btrfs_run_defrag_inodes(root->fs_info);
 sleep: