scsi: lpfc: Fix memory leak in abnormal exit path from lpfc_eq_create

eq create is leaking mailbox memory if it encounters an error.

rework error path to free the memory.

Signed-off-by: Dick Kennedy <dick.kennedy@broadcom.com>
Signed-off-by: James Smart <jsmart2021@gmail.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

diff --git a/drivers/scsi/lpfc/lpfc_sli.c b/drivers/scsi/lpfc/lpfc_sli.c
index 946f3024d4db4a7f03c97f1b7de4f4923c295c8e..4432060f73151ec681f30795d59c4d9728a05bd5 100644 (file)
--- a/drivers/scsi/lpfc/lpfc_sli.c
+++ b/drivers/scsi/lpfc/lpfc_sli.c
@@ -14641,8 +14641,10 @@ lpfc_eq_create(struct lpfc_hba *phba, struct lpfc_queue *eq, uint32_t imax)
                lpfc_printf_log(phba, KERN_ERR, LOG_SLI,
                                "0360 Unsupported EQ count. (%d)\n",
                                eq->entry_count);
-               if (eq->entry_count < 256)
-                       return -EINVAL;
+               if (eq->entry_count < 256) {
+                       status = -EINVAL;
+                       goto out;
+               }
                /* fall through - otherwise default to smallest count */
        case 256:
                bf_set(lpfc_eq_context_count, &eq_create->u.request.context,
@@ -14694,7 +14696,7 @@ lpfc_eq_create(struct lpfc_hba *phba, struct lpfc_queue *eq, uint32_t imax)
        eq->host_index = 0;
        eq->notify_interval = LPFC_EQ_NOTIFY_INTRVL;
        eq->max_proc_limit = LPFC_EQ_MAX_PROC_LIMIT;
-
+out:
        mempool_free(mbox, phba->mbox_mem_pool);
        return status;
 }