spi: spi-geni-qcom: Don't initialize completion for normal message
authorStephen Boyd <swboyd@chromium.org>
Thu, 10 Jan 2019 21:02:52 +0000 (13:02 -0800)
committerMark Brown <broonie@kernel.org>
Mon, 14 Jan 2019 12:22:11 +0000 (12:22 +0000)
We only use this completion when we're doing something that isn't a
message transfer. For example, changing CS or aborting/canceling a
command. All of those situations properly reinitialize the completion
before sending the GENI the special command to change CS or cancel, etc.
Given that, let's remove the initialization here.

Cc: Girish Mahadevan <girishm@codeaurora.org>
Cc: Dilip Kota <dkota@codeaurora.org>
Cc: Alok Chauhan <alokc@codeaurora.org>
Cc: Douglas Anderson <dianders@chromium.org>
Signed-off-by: Stephen Boyd <swboyd@chromium.org>
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-geni-qcom.c

index fdb7cb88fb5673aeebdb36887ea2befea1240513..c3e9464027d45519631c50ee65acef02a77e9a02 100644 (file)
@@ -233,7 +233,6 @@ static int spi_geni_prepare_message(struct spi_master *spi,
        struct geni_se *se = &mas->se;
 
        geni_se_select_mode(se, GENI_SE_FIFO);
-       reinit_completion(&mas->xfer_done);
        ret = setup_fifo_params(spi_msg->spi, spi);
        if (ret)
                dev_err(mas->dev, "Couldn't select mode %d\n", ret);