staging: media: lirc: fix multiple issues with function arguments
authorAya Mahfouz <mahfouz.saif.elyazal@gmail.com>
Tue, 10 Mar 2015 16:56:37 +0000 (18:56 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 15 Mar 2015 17:41:11 +0000 (18:41 +0100)
Handles the following issues:

Removing extra parentheses around function arguments,
Removing unnecessary pointer to pointer casts.

Issues detected and resolved using the following coccinelle
script:

@@
expression e;
type t;
identifier f;
@@

f(...,
-(t *)
e
,...)

@@
expression e;
identifier f;
@@

f(...,
&
-(
e
-)
,...)

@@
expression e;
identifier f;
@@

f(...,
-(
e
-)
,...)

Signed-off-by: Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/media/lirc/lirc_sasem.c

index 9944af1ba4d3249216f9f57632ce5077c3756a44..b9c53e2d5d29a39d9391c3d3876eaddbcfbb8b2b 100644 (file)
@@ -331,11 +331,11 @@ static int send_packet(struct sasem_context *context)
        context->tx_urb->actual_length = 0;
 
        init_completion(&context->tx.finished);
-       atomic_set(&(context->tx.busy), 1);
+       atomic_set(&context->tx.busy, 1);
 
        retval =  usb_submit_urb(context->tx_urb, GFP_KERNEL);
        if (retval) {
-               atomic_set(&(context->tx.busy), 0);
+               atomic_set(&context->tx.busy, 0);
                dev_err(&context->dev->dev, "error submitting urb (%d)\n",
                        retval);
        } else {
@@ -387,7 +387,7 @@ static ssize_t vfd_write(struct file *file, const char __user *buf,
                goto exit;
        }
 
-       data_buf = memdup_user((void const __user *)buf, n_bytes);
+       data_buf = memdup_user(buf, n_bytes);
        if (IS_ERR(data_buf)) {
                retval = PTR_ERR(data_buf);
                data_buf = NULL;