staging: comedi: pcl816: remove #if 0'ed out code
authorH Hartley Sweeten <hsweeten@visionengravers.com>
Mon, 5 Oct 2015 22:44:04 +0000 (15:44 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 13 Oct 2015 04:20:48 +0000 (21:20 -0700)
Remove the #if 0'ed out code that would initialize an analog output
subdevice.

The hardware does not normally support an analog output subdevice.
Analog outputs are only supported with additional "piggyback" modules.
Support for these modules is not included in the driver.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/comedi/drivers/pcl816.c

index aa775b6aa825af21e18cb0c0c3f6f793a75b4bf9..c00a71f538efc14364ddb757c67f816580f4a694 100644 (file)
@@ -86,7 +86,6 @@ static const struct comedi_lrange range_pcl816 = {
 struct pcl816_board {
        const char *name;
        int ai_maxdata;
-       int ao_maxdata;
        int ai_chanlist;
 };
 
@@ -94,12 +93,10 @@ static const struct pcl816_board boardtypes[] = {
        {
                .name           = "pcl816",
                .ai_maxdata     = 0xffff,
-               .ao_maxdata     = 0xffff,
                .ai_chanlist    = 1024,
        }, {
                .name           = "pcl814b",
                .ai_maxdata     = 0x3fff,
-               .ao_maxdata     = 0x3fff,
                .ai_chanlist    = 1024,
        },
 };
@@ -645,16 +642,9 @@ static int pcl816_attach(struct comedi_device *dev, struct comedi_devconfig *it)
                s->cancel       = pcl816_ai_cancel;
        }
 
-       /* Analog OUtput subdevice */
-       s = &dev->subdevices[2];
+       /* Piggyback Slot1 subdevice */
+       s = &dev->subdevices[1];
        s->type         = COMEDI_SUBD_UNUSED;
-#if 0
-       subdevs[1] = COMEDI_SUBD_AO;
-       s->subdev_flags = SDF_WRITABLE | SDF_GROUND;
-       s->n_chan = 1;
-       s->maxdata = board->ao_maxdata;
-       s->range_table = &range_pcl816;
-#endif
 
        /* Digital Input subdevice */
        s = &dev->subdevices[2];