drm/amdgpu: fix wrong APU judgement
authorEvan Quan <evan.quan@amd.com>
Wed, 16 Jan 2019 06:11:50 +0000 (14:11 +0800)
committerAlex Deucher <alexander.deucher@amd.com>
Fri, 25 Jan 2019 21:15:35 +0000 (16:15 -0500)
Fix the APU judgement to make it really work as expected.

Signed-off-by: Evan Quan <evan.quan@amd.com>
Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c

index 4099c6b97cb1dce84e22c532edc73b9f7ec0fbde..250be1ef171919ca3617a131dd828e1829217ef2 100644 (file)
@@ -2429,7 +2429,7 @@ int amdgpu_pm_sysfs_init(struct amdgpu_device *adev)
                return ret;
        }
        /* PCIe Perf counters won't work on APU nodes */
-       if (adev->flags & !AMD_IS_APU) {
+       if (!(adev->flags & AMD_IS_APU)) {
                ret = device_create_file(adev->dev, &dev_attr_pcie_bw);
                if (ret) {
                        DRM_ERROR("failed to create device file pcie_bw\n");
@@ -2492,7 +2492,7 @@ void amdgpu_pm_sysfs_fini(struct amdgpu_device *adev)
                device_remove_file(adev->dev,
                                &dev_attr_pp_od_clk_voltage);
        device_remove_file(adev->dev, &dev_attr_gpu_busy_percent);
-       if (adev->flags & !AMD_IS_APU)
+       if (!(adev->flags & AMD_IS_APU))
                device_remove_file(adev->dev, &dev_attr_pcie_bw);
        if ((adev->asic_type >= CHIP_VEGA10) &&
            !(adev->flags & AMD_IS_APU))