svcrpc: no need for XPT_DEAD check in svc_xprt_enqueue
authorJ. Bruce Fields <bfields@redhat.com>
Sat, 23 Oct 2010 15:23:46 +0000 (11:23 -0400)
committerJ. Bruce Fields <bfields@redhat.com>
Mon, 25 Oct 2010 21:59:33 +0000 (17:59 -0400)
If any xprt marked DEAD is also left BUSY for the rest of its life, then
the XPT_DEAD check here is superfluous--we'll get the same result from
the XPT_BUSY check just after.

Signed-off-by: J. Bruce Fields <bfields@redhat.com>
net/sunrpc/svc_xprt.c

index c65a47218290176571999617cf4d1a3dad1239d9..c82fe739fbdcc685fae1e59f1fdb7c9e5afd30b0 100644 (file)
@@ -330,12 +330,6 @@ void svc_xprt_enqueue(struct svc_xprt *xprt)
                       "svc_xprt_enqueue: "
                       "threads and transports both waiting??\n");
 
-       if (test_bit(XPT_DEAD, &xprt->xpt_flags)) {
-               /* Don't enqueue dead transports */
-               dprintk("svc: transport %p is dead, not enqueued\n", xprt);
-               goto out_unlock;
-       }
-
        pool->sp_stats.packets++;
 
        /* Mark transport as busy. It will remain in this state until