[media] ivtv: Replace memcpy with struct assignment

This kind of memcpy() is error-prone. Its replacement with a struct
assignment is prefered because it's type-safe and much easier to read.
Found by coccinelle. Hand patched and reviewed.
Tested by compilation only.
A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)
// <smpl>
@@
identifier struct_name;
struct struct_name to;
struct struct_name from;
expression E;
@@
-memcpy(&(to), &(from), E);
+to = from;
// </smpl>

Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
Signed-off-by: Ezequiel Garcia <elezegarcia@gmail.com>
Signed-off-by: Andy Walls <awalls@md.metrocast.net>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>

diff --git a/drivers/media/pci/ivtv/ivtv-i2c.c b/drivers/media/pci/ivtv/ivtv-i2c.c
index 46e262becb6728615fad39494aea4bf48b978f2c..a1811054fde4d4a39c8822bb0d9c34221d746c92 100644 (file)
--- a/drivers/media/pci/ivtv/ivtv-i2c.c
+++ b/drivers/media/pci/ivtv/ivtv-i2c.c
@@ -719,13 +719,10 @@ int init_ivtv_i2c(struct ivtv *itv)
                return -ENODEV;
        }
        if (itv->options.newi2c > 0) {
-               memcpy(&itv->i2c_adap, &ivtv_i2c_adap_hw_template,
-                      sizeof(struct i2c_adapter));
+               itv->i2c_adap = ivtv_i2c_adap_hw_template;
        } else {
-               memcpy(&itv->i2c_adap, &ivtv_i2c_adap_template,
-                      sizeof(struct i2c_adapter));
-               memcpy(&itv->i2c_algo, &ivtv_i2c_algo_template,
-                      sizeof(struct i2c_algo_bit_data));
+               itv->i2c_adap = ivtv_i2c_adap_template;
+               itv->i2c_algo = ivtv_i2c_algo_template;
        }
        itv->i2c_algo.udelay = itv->options.i2c_clock_period / 2;
        itv->i2c_algo.data = itv;
@@ -735,8 +732,7 @@ int init_ivtv_i2c(struct ivtv *itv)
                itv->instance);
        i2c_set_adapdata(&itv->i2c_adap, &itv->v4l2_dev);
 
-       memcpy(&itv->i2c_client, &ivtv_i2c_client_template,
-              sizeof(struct i2c_client));
+       itv->i2c_client = ivtv_i2c_client_template;
        itv->i2c_client.adapter = &itv->i2c_adap;
        itv->i2c_adap.dev.parent = &itv->pdev->dev;