drop_monitor: Document scope of spinlock
authorIdo Schimmel <idosch@mellanox.com>
Tue, 6 Aug 2019 13:19:53 +0000 (16:19 +0300)
committerDavid S. Miller <davem@davemloft.net>
Tue, 6 Aug 2019 19:37:56 +0000 (12:37 -0700)
While 'per_cpu_dm_data' is a per-CPU variable, its 'skb' and
'send_timer' fields can be accessed concurrently by the CPU sending the
netlink notification to user space from the workqueue and the CPU
tracing kfree_skb(). This spinlock is meant to protect against that.

Document its scope and suppress the checkpatch message "spinlock_t
definition without comment".

Signed-off-by: Ido Schimmel <idosch@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/core/drop_monitor.c

index 000ec8b66d1e1668ca068c71bfd9a67ecfa162dc..35d31b007da416cbbea66e84dceb0ffeca2235cc 100644 (file)
@@ -52,7 +52,7 @@ static int trace_state = TRACE_OFF;
 static DEFINE_MUTEX(net_dm_mutex);
 
 struct per_cpu_dm_data {
-       spinlock_t              lock;
+       spinlock_t              lock;   /* Protects 'skb' and 'send_timer' */
        struct sk_buff          *skb;
        struct work_struct      dm_alert_work;
        struct timer_list       send_timer;