selftests: forwarding: mirror_lib: Update ping limits
authorPetr Machata <petrm@mellanox.com>
Thu, 31 Jan 2019 22:35:12 +0000 (22:35 +0000)
committerDavid S. Miller <davem@davemloft.net>
Fri, 1 Feb 2019 23:26:36 +0000 (15:26 -0800)
The current ping intervals are too short for running mirroring tests in
simulator. This leads to ping sending a follow-up ping before the reply
arrives, thus sending more than the requested 10 ICMP requests. Those
are mirrored, and over a certain threshold the test case run is
considered a failure, because too much traffic is observed.

Bump interval and timeout numbers 5x in mirroring tests to address the
spurious failures.

Signed-off-by: Petr Machata <petrm@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
tools/testing/selftests/net/forwarding/mirror_lib.sh

index a1c0389eb04971b351011ab055c75928ccdf611f..878f8d53327a34fcc0c63251b9da89e0b94720d9 100644 (file)
@@ -29,10 +29,11 @@ mirror_test()
        local pref=$1; shift
        local expect=$1; shift
 
+       local ping_timeout=$((PING_TIMEOUT * 5))
        local t0=$(tc_rule_stats_get $dev $pref)
        ip vrf exec $vrf_name \
-          ${PING} ${sip:+-I $sip} $dip -c 10 -i 0.1 -w $PING_TIMEOUT \
-          &> /dev/null
+          ${PING} ${sip:+-I $sip} $dip -c 10 -i 0.5 -w $ping_timeout \
+                  &> /dev/null
        local t1=$(tc_rule_stats_get $dev $pref)
        local delta=$((t1 - t0))
        # Tolerate a couple stray extra packets.