crypto: ccree - fix memdup.cocci warnings
authorFengguang Wu <fengguang.wu@intel.com>
Thu, 15 Feb 2018 16:40:13 +0000 (00:40 +0800)
committerHerbert Xu <herbert@gondor.apana.org.au>
Thu, 22 Feb 2018 14:17:01 +0000 (22:17 +0800)
drivers/crypto/ccree/cc_cipher.c:629:15-22: WARNING opportunity for kmemdep

 Use kmemdup rather than duplicating its implementation

Generated by: scripts/coccinelle/api/memdup.cocci

Fixes: 63ee04c8b491 ("crypto: ccree - add skcipher support")
CC: Gilad Ben-Yossef <gilad@benyossef.com>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
drivers/crypto/ccree/cc_cipher.c

index 5760ca9481eadc190d730d4aa165506ed2b66bc7..1aa7c56dbc02b8b650745ef7d94f89b912299dfc 100644 (file)
@@ -626,12 +626,11 @@ static int cc_cipher_process(struct skcipher_request *req,
        /* The IV we are handed may be allocted from the stack so
         * we must copy it to a DMAable buffer before use.
         */
-       req_ctx->iv = kmalloc(ivsize, flags);
+       req_ctx->iv = kmemdup(iv, ivsize, flags);
        if (!req_ctx->iv) {
                rc = -ENOMEM;
                goto exit_process;
        }
-       memcpy(req_ctx->iv, iv, ivsize);
 
        /*For CTS in case of data size aligned to 16 use CBC mode*/
        if (((nbytes % AES_BLOCK_SIZE) == 0) &&