null_blk: remove NULLB_DEV_FL_CONFIGURED on turning off nullb device
authorLiu Bo <bo.liu@linux.alibaba.com>
Thu, 5 Jul 2018 19:07:13 +0000 (03:07 +0800)
committerJens Axboe <axboe@kernel.dk>
Mon, 9 Jul 2018 15:07:54 +0000 (09:07 -0600)
Currently mbps knob could only be set once before switching power knob to
on, after power knob has been set at least once, there is no way to set
mbps knob again due to -EBUSY.

As nullb is mainly used for testing, in order to make it flexible, this
removes the flag NULLB_DEV_FL_CONFIGURED so that mbps knob can be reset
when power knob is off, e.g.

echo 0 > /config/nullb/a/power
echo 40 > /config/nullb/a/mbps
echo 1 > /config/nullb/a/power

So does other knobs under /config/nullb/a.

Signed-off-by: Liu Bo <bo.liu@linux.alibaba.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
drivers/block/null_blk.c

index 042c778e5a4e0bf2009c38a6b1cf37bc5d23ce89..8abfb1059909b5afe1830fdf663ed1b359bb5c95 100644 (file)
@@ -390,6 +390,7 @@ static ssize_t nullb_device_power_store(struct config_item *item,
                null_del_dev(dev->nullb);
                mutex_unlock(&lock);
                clear_bit(NULLB_DEV_FL_UP, &dev->flags);
+               clear_bit(NULLB_DEV_FL_CONFIGURED, &dev->flags);
        }
 
        return count;