staging: greybus: convert to DEFINE_SHOW_ATTRIBUTE
authorYangtao Li <tiny.windzz@gmail.com>
Sat, 15 Dec 2018 08:53:12 +0000 (03:53 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 17 Dec 2018 13:24:42 +0000 (14:24 +0100)
Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code.

Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/greybus/loopback.c

index 28973c2464744953d7a40b89f657e5c1eabc016c..48d85ebe404a1d727a9a083761978c3763d4fcb3 100644 (file)
@@ -970,19 +970,7 @@ static int gb_loopback_dbgfs_latency_show(struct seq_file *s, void *unused)
        return gb_loopback_dbgfs_latency_show_common(s, &gb->kfifo_lat,
                                                     &gb->mutex);
 }
-
-static int gb_loopback_latency_open(struct inode *inode, struct file *file)
-{
-       return single_open(file, gb_loopback_dbgfs_latency_show,
-                          inode->i_private);
-}
-
-static const struct file_operations gb_loopback_debugfs_latency_ops = {
-       .open           = gb_loopback_latency_open,
-       .read           = seq_read,
-       .llseek         = seq_lseek,
-       .release        = single_release,
-};
+DEFINE_SHOW_ATTRIBUTE(gb_loopback_dbgfs_latency);
 
 #define DEBUGFS_NAMELEN 32
 
@@ -1042,7 +1030,7 @@ static int gb_loopback_probe(struct gb_bundle *bundle,
        snprintf(name, sizeof(name), "raw_latency_%s",
                 dev_name(&connection->bundle->dev));
        gb->file = debugfs_create_file(name, S_IFREG | 0444, gb_dev.root, gb,
-                                      &gb_loopback_debugfs_latency_ops);
+                                      &gb_loopback_dbgfs_latency_fops);
 
        gb->id = ida_simple_get(&loopback_ida, 0, 0, GFP_KERNEL);
        if (gb->id < 0) {