scsi: iscsi: qla4xxx: fix double free in probe
authorDan Carpenter <dan.carpenter@oracle.com>
Tue, 3 Dec 2019 09:45:09 +0000 (12:45 +0300)
committerMartin K. Petersen <martin.petersen@oracle.com>
Tue, 10 Dec 2019 00:01:51 +0000 (19:01 -0500)
commitfee92f25777789d73e1936b91472e9c4644457c8
treeffc988a7c30a5a5cd823cdce73678295964ac3d2
parent8c850a0296004409e7bcb9464712fb2807da656a
scsi: iscsi: qla4xxx: fix double free in probe

On this error path we call qla4xxx_mem_free() and then the caller also
calls qla4xxx_free_adapter() which calls qla4xxx_mem_free().  It leads to a
couple double frees:

drivers/scsi/qla4xxx/ql4_os.c:8856 qla4xxx_probe_adapter() warn: 'ha->chap_dma_pool' double freed
drivers/scsi/qla4xxx/ql4_os.c:8856 qla4xxx_probe_adapter() warn: 'ha->fw_ddb_dma_pool' double freed

Fixes: afaf5a2d341d ("[SCSI] Initial Commit of qla4xxx")
Link: https://lore.kernel.org/r/20191203094421.hw7ex7qr3j2rbsmx@kili.mountain
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/qla4xxx/ql4_os.c