powerpc/32: Fix early boot failure with RTAS built-in
authorChristophe Leroy <christophe.leroy@c-s.fr>
Mon, 25 Mar 2019 08:43:33 +0000 (08:43 +0000)
committerMichael Ellerman <mpe@ellerman.id.au>
Mon, 1 Apr 2019 11:32:52 +0000 (22:32 +1100)
commitfd427103e8dfcb4b438269afd710b63e7af61463
tree083237cf729e12e6e4f545721571eb787efa3f42
parent6f845ebec2706841d15831fab3ffffcfd9e676fa
powerpc/32: Fix early boot failure with RTAS built-in

Commit 0df977eafc79 ("powerpc/6xx: Don't use SPRN_SPRG2 for storing
stack pointer while in RTAS") changes the code to use a field in
thread struct to store the stack pointer while in RTAS instead of
using SPRN_SPRG2. It therefore converts all places which were
manipulating SPRN_SPRG2 to use that field. During early startup, the
zeroing of SPRN_SPRG2 has been replaced by a zeroing of that field in
thread struct. But at least in start_here, that's done wrongly because
it used the physical address of the fields while MMU is on at that
time.

So the virtual address of the field should be used instead, but in
the meantime, thread struct has already been zeroed and initialised
so we can just drop this initialisation.

Reported-by: Larry Finger <Larry.Finger@lwfinger.net>
Fixes: 0df977eafc79 ("powerpc/6xx: Don't use SPRN_SPRG2 for storing stack pointer while in RTAS")
Signed-off-by: Christophe Leroy <christophe.leroy@c-s.fr>
Tested-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
arch/powerpc/kernel/head_32.S