slab: fix a crash by reading /proc/slab_allocators
authorQian Cai <cai@lca.pw>
Sat, 6 Apr 2019 22:59:01 +0000 (18:59 -0400)
committerLinus Torvalds <torvalds@linux-foundation.org>
Mon, 8 Apr 2019 05:23:12 +0000 (19:23 -1000)
commitfcf88917dd435c6a4cb2830cb086ee58605a1d85
treeec4e3e2411c268134933c6a0fc759f057d42161e
parent15ade5d2e7775667cf191cf2f94327a4889f8b9d
slab: fix a crash by reading /proc/slab_allocators

The commit 510ded33e075 ("slab: implement slab_root_caches list")
changes the name of the list node within "struct kmem_cache" from "list"
to "root_caches_node", but leaks_show() still use the "list" which
causes a crash when reading /proc/slab_allocators.

You need to have CONFIG_SLAB=y and CONFIG_MEMCG=y to see the problem,
because without MEMCG all slab caches are root caches, and the "list"
node happens to be the right one.

Fixes: 510ded33e075 ("slab: implement slab_root_caches list")
Signed-off-by: Qian Cai <cai@lca.pw>
Reviewed-by: Tobin C. Harding <tobin@kernel.org>
Cc: Tejun Heo <tj@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
mm/slab.c