ping: Fix race in free in receive path
authorsubashab@codeaurora.org <subashab@codeaurora.org>
Fri, 23 Jan 2015 22:26:02 +0000 (22:26 +0000)
committerDavid S. Miller <davem@davemloft.net>
Tue, 27 Jan 2015 08:04:53 +0000 (00:04 -0800)
commitfc752f1f43c1c038a2c6ae58cc739ebb5953ccb0
tree4766edc6b35f44ab035c41d60d0d9b8212b6e52d
parent86f3cddbc3037882414c7308973530167906b7e9
ping: Fix race in free in receive path

An exception is seen in ICMP ping receive path where the skb
destructor sock_rfree() tries to access a freed socket. This happens
because ping_rcv() releases socket reference with sock_put() and this
internally frees up the socket. Later icmp_rcv() will try to free the
skb and as part of this, skb destructor is called and which leads
to a kernel panic as the socket is freed already in ping_rcv().

-->|exception
-007|sk_mem_uncharge
-007|sock_rfree
-008|skb_release_head_state
-009|skb_release_all
-009|__kfree_skb
-010|kfree_skb
-011|icmp_rcv
-012|ip_local_deliver_finish

Fix this incorrect free by cloning this skb and processing this cloned
skb instead.

This patch was suggested by Eric Dumazet

Signed-off-by: Subash Abhinov Kasiviswanathan <subashab@codeaurora.org>
Cc: Eric Dumazet <edumazet@google.com>
Signed-off-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv4/ping.c