ip_tunnel: Emit events for post-register MTU changes
authorPetr Machata <petrm@mellanox.com>
Thu, 22 Mar 2018 17:53:33 +0000 (19:53 +0200)
committerDavid S. Miller <davem@davemloft.net>
Fri, 23 Mar 2018 16:54:34 +0000 (12:54 -0400)
commitf6cc9c054e77b9a28d4594bcc201697edb21dfd2
treebbe5149057467d5c4555189466cb56b5f45b38e3
parentf36b7534b83357cf52e747905de6d65b4f7c2512
ip_tunnel: Emit events for post-register MTU changes

For tunnels created with IFLA_MTU, MTU of the netdevice is set by
rtnl_create_link() (called from rtnl_newlink()) before the device is
registered. However without IFLA_MTU that's not done.

rtnl_newlink() proceeds by calling struct rtnl_link_ops.newlink, which
via ip_tunnel_newlink() calls register_netdevice(), and that emits
NETDEV_REGISTER. Thus any listeners that inspect the netdevice get the
MTU of 0.

After ip_tunnel_newlink() corrects the MTU after registering the
netdevice, but since there's no event, the listeners don't get to know
about the MTU until something else happens--such as a NETDEV_UP event.
That's not ideal.

So instead of setting the MTU directly, go through dev_set_mtu(), which
takes care of distributing the necessary NETDEV_PRECHANGEMTU and
NETDEV_CHANGEMTU events.

Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Signed-off-by: Petr Machata <petrm@mellanox.com>
Signed-off-by: Ido Schimmel <idosch@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv4/ip_tunnel.c