ALSA: usb-audio: Fix potential out-of-bound access at parsing SU
authorTakashi Iwai <tiwai@suse.de>
Tue, 21 Nov 2017 16:00:32 +0000 (17:00 +0100)
committerTakashi Iwai <tiwai@suse.de>
Tue, 21 Nov 2017 16:50:31 +0000 (17:50 +0100)
commitf658f17b5e0e339935dca23e77e0f3cad591926b
treebb2746f2604b3c41bd44c9b0f181ed47d6fc86fa
parentd937cd6790a2bef2d07b500487646bd794c039bb
ALSA: usb-audio: Fix potential out-of-bound access at parsing SU

The usb-audio driver may trigger an out-of-bound access at parsing a
malformed selector unit, as it checks the header length only after
evaluating bNrInPins field, which can be already above the given
length.  Fix it by adding the length check beforehand.

Fixes: 99fc86450c43 ("ALSA: usb-mixer: parse descriptors with structs")
Cc: <stable@vger.kernel.org>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/usb/mixer.c