netfilter: nf_conntrack_h323: restore boundary check correctness
authorJakub Jankowski <shasta@toxcorp.com>
Thu, 25 Apr 2019 21:46:50 +0000 (23:46 +0200)
committerPablo Neira Ayuso <pablo@netfilter.org>
Sun, 5 May 2019 22:36:17 +0000 (00:36 +0200)
commitf5e85ce8e733c2547827f6268136b70b802eabdb
tree53938cb6e125dbb15a2cda02814a44e816b2cfd8
parent33cc3c0cfa64c86b6c4bbee86997aea638534931
netfilter: nf_conntrack_h323: restore boundary check correctness

Since commit bc7d811ace4a ("netfilter: nf_ct_h323: Convert
CHECK_BOUND macro to function"), NAT traversal for H.323
doesn't work, failing to parse H323-UserInformation.
nf_h323_error_boundary() compares contents of the bitstring,
not the addresses, preventing valid H.323 packets from being
conntrack'd.

This looks like an oversight from when CHECK_BOUND macro was
converted to a function.

To fix it, stop dereferencing bs->cur and bs->end.

Fixes: bc7d811ace4a ("netfilter: nf_ct_h323: Convert CHECK_BOUND macro to function")
Signed-off-by: Jakub Jankowski <shasta@toxcorp.com>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
net/netfilter/nf_conntrack_h323_asn1.c