projects / openwrt / staging / blogic.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: c5eb2a2) | patch
[ARM] rtc-pcf8583: don't use BCD_TO_BIN/BIN_TO_BCD
authorRussell King <rmk@dyn-67.arm.linux.org.uk>
Sun, 4 Mar 2007 20:12:07 +0000 (20:12 +0000)
committerRussell King <rmk+kernel@arm.linux.org.uk>
Sun, 4 Mar 2007 20:12:07 +0000 (20:12 +0000)
commitf5e5b734d4c9ccc1f5f68bdf545bdc4b19681d28
tree7b4e206c499af24d2dad42172a52a2d215b29c76tree | snapshot
parentc5eb2a2b65fe411dcfe13264cfa84788a75341fbcommit | diff
[ARM] rtc-pcf8583: don't use BCD_TO_BIN/BIN_TO_BCD

Both BCD_TO_BIN(x) and BIN_TO_BCD(x) have an unexpected side-effect -
not only do they return the value as expected, they _modify_ their
argument in the process.

Let's play it safe and avoid these macros.

Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
drivers/rtc/rtc-pcf8583.c diff | blob | history
John Crispins staging tree