jffs2: Fix possible null-pointer dereferences in jffs2_add_frag_to_fragtree()
authorJia-Ju Bai <baijiaju1990@gmail.com>
Wed, 24 Jul 2019 02:46:58 +0000 (10:46 +0800)
committerRichard Weinberger <richard@nod.at>
Sun, 15 Sep 2019 20:42:10 +0000 (22:42 +0200)
commitf2538f999345405f7d2e1194c0c8efa4e11f7b3a
tree3d7558b9a985024eb9eb80cda548153d5f89c858
parente46131b9fd31155a552dea598e7d915b64c5c04c
jffs2: Fix possible null-pointer dereferences in jffs2_add_frag_to_fragtree()

In jffs2_add_frag_to_fragtree(), there is an if statement on line 223 to
check whether "this" is NULL:
    if (this)

When "this" is NULL, it is used at several places, such as on line 249:
    if (this->node)
and on line 260:
    if (newfrag->ofs > this->ofs)

Thus possible null-pointer dereferences may occur.

To fix these bugs, -EINVAL is returned when "this" is NULL.

These bugs are found by a static analysis tool STCheck written by us.

Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Signed-off-by: Richard Weinberger <richard@nod.at>
fs/jffs2/nodelist.c