target: Fix alua_access_state attribute OOPs for un-configured devices
authorNicholas Bellinger <nab@linux-iscsi.org>
Fri, 6 Jun 2014 07:52:57 +0000 (00:52 -0700)
committerNicholas Bellinger <nab@linux-iscsi.org>
Fri, 6 Jun 2014 08:22:41 +0000 (01:22 -0700)
commitf1453773514bb8b0bba0716301e8c8f17f8d39c7
treefd8b84b89093cfd1c148413250a2aa26af394106
parente7810c2d2c37fa8e58dda74b00790dab60fe6fba
target: Fix alua_access_state attribute OOPs for un-configured devices

This patch fixes a OOPs where an attempt to write to the per-device
alua_access_state configfs attribute at:

  /sys/kernel/config/target/core/$HBA/$DEV/alua/$TG_PT_GP/alua_access_state

results in an NULL pointer dereference when the backend device has not
yet been configured.

This patch adds an explicit check for DF_CONFIGURED, and fails with
-ENODEV to avoid this case.

Reported-by: Chris Boot <crb@tiger-computing.co.uk>
Reported-by: Philip Gaw <pgaw@darktech.org.uk>
Cc: Chris Boot <crb@tiger-computing.co.uk>
Cc: Philip Gaw <pgaw@darktech.org.uk>
Cc: stable@vger.kernel.org # 3.8+
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
drivers/target/target_core_configfs.c