page_pool: help compiler remove code in case CONFIG_NUMA=n
authorJesper Dangaard Brouer <brouer@redhat.com>
Fri, 27 Dec 2019 17:13:24 +0000 (18:13 +0100)
committerDavid S. Miller <davem@davemloft.net>
Thu, 2 Jan 2020 23:37:52 +0000 (15:37 -0800)
commitf13fc10785bc04f83fe0d7730beb8ff4be563a20
tree9284b79bba0aa682bb0019f1165a5fb50c6edace
parent44768decb7c0a6c7c01995dbacc864f3921b6dac
page_pool: help compiler remove code in case CONFIG_NUMA=n

When kernel is compiled without NUMA support, then page_pool NUMA
config setting (pool->p.nid) doesn't make any practical sense. The
compiler cannot see that it can remove the code paths.

This patch avoids reading pool->p.nid setting in case of !CONFIG_NUMA,
in allocation and numa check code, which helps compiler to see the
optimisation potential. It leaves update code intact to keep API the
same.

 $ ./scripts/bloat-o-meter net/core/page_pool.o-numa-enabled \
                           net/core/page_pool.o-numa-disabled
 add/remove: 0/0 grow/shrink: 0/3 up/down: 0/-113 (-113)
 Function                                     old     new   delta
 page_pool_create                             401     398      -3
 __page_pool_alloc_pages_slow                 439     426     -13
 page_pool_refill_alloc_cache                 425     328     -97
 Total: Before=3611, After=3498, chg -3.13%

Signed-off-by: Jesper Dangaard Brouer <brouer@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/core/page_pool.c