drm/i915/execlists: Clear user-active flag on preemption completion
authorChris Wilson <chris@chris-wilson.co.uk>
Sat, 24 Mar 2018 12:58:29 +0000 (12:58 +0000)
committerChris Wilson <chris@chris-wilson.co.uk>
Tue, 27 Mar 2018 10:02:27 +0000 (11:02 +0100)
commiteed7ec52f214bac2f25395ccaad610fbeb842a6e
tree5ff794f27b0b947e0ae74104c6cc5573e6719041
parent7487508eff1fe787573aa6e0f3daaa6b12bd4520
drm/i915/execlists: Clear user-active flag on preemption completion

When cancelling the requests and clearing out the ports following a
successful preemption completion, also clear the active flag. I had
assumed that all preemptions would be followed by an immediate dequeue
(preserving the active user flag), but under rare circumstances we may
be triggering a preemption for the second port only for it to have
completed before the preemotion kicks in; leaving execlists->active set
even though the system is now idle.

We can clear the flag inside the common execlists_cancel_port_requests()
as the other users also expect the semantics of active being cleared.

Fixes: f6322eddaff7 ("drm/i915/preemption: Allow preemption between submission ports")
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: MichaƂ Winiarski <michal.winiarski@intel.com>
Cc: Michel Thierry <michel.thierry@intel.com>
Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20180324125829.27026-1-chris@chris-wilson.co.uk
drivers/gpu/drm/i915/intel_lrc.c