nfp: flower: fix port metadata conversion bug
authorJohn Hurley <john.hurley@netronome.com>
Sat, 28 Jul 2018 03:56:52 +0000 (20:56 -0700)
committerDavid S. Miller <davem@davemloft.net>
Sat, 28 Jul 2018 21:27:32 +0000 (14:27 -0700)
commitee614c871014045b45fae149b7245fc22a0bbdd8
tree41061399f4985128c4b2067400f4389886d53602
parentd0fdb366b6936f1ddfb4de2631484d58967a7efd
nfp: flower: fix port metadata conversion bug

Function nfp_flower_repr_get_type_and_port expects an enum nfp_repr_type
return value but, if the repr type is unknown, returns a value of type
enum nfp_flower_cmsg_port_type.  This means that if FW encodes the port
ID in a way the driver does not understand instead of dropping the frame
driver may attribute it to a physical port (uplink) provided the port
number is less than physical port count.

Fix this and ensure a net_device of NULL is returned if the repr can not
be determined.

Fixes: 1025351a88a4 ("nfp: add flower app")
Signed-off-by: John Hurley <john.hurley@netronome.com>
Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/netronome/nfp/flower/main.c