ext4: do not delete unlinked inode from orphan list on failed truncate
authorJan Kara <jack@suse.cz>
Fri, 24 May 2019 03:35:28 +0000 (23:35 -0400)
committerTheodore Ts'o <tytso@mit.edu>
Fri, 24 May 2019 03:35:28 +0000 (23:35 -0400)
commitee0ed02ca93ef1ecf8963ad96638795d55af2c14
treed466f5a61e165caf2a4a70b27234d448a361664d
parent82a25b027ca48d7ef197295846b352345853dfa8
ext4: do not delete unlinked inode from orphan list on failed truncate

It is possible that unlinked inode enters ext4_setattr() (e.g. if
somebody calls ftruncate(2) on unlinked but still open file). In such
case we should not delete the inode from the orphan list if truncate
fails. Note that this is mostly a theoretical concern as filesystem is
corrupted if we reach this path anyway but let's be consistent in our
orphan handling.

Reviewed-by: Ira Weiny <ira.weiny@intel.com>
Signed-off-by: Jan Kara <jack@suse.cz>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Cc: stable@kernel.org
fs/ext4/inode.c