kconfig: do not overwrite symbol direct dependency in assignment
authorArnaud Lacombe <lacombar@gmail.com>
Wed, 8 Jun 2011 05:42:11 +0000 (01:42 -0400)
committerMichal Marek <mmarek@suse.cz>
Fri, 24 Jun 2011 15:21:27 +0000 (17:21 +0200)
commitec6452a5ec68498221a0ced3443cefd65b08be36
tree74db3525b2a439465ec40406ac98ba5b35c7fd03
parent36fee53510f91d8ac5eb5dcba0e431a21ebdd5cd
kconfig: do not overwrite symbol direct dependency in assignment

Considering the following configuration:

config F
    bool "F"

choice AB
    bool "AB"
config A
    bool "A"
config B
    bool "B"
endchoice

if A
config D
    bool
    default y if F
    select E
config E
    bool "E"
endif

if B
config D
    bool
    default y if F
    select E
config E
    bool "E"
endif

The following configuration:

 CONFIG_F=y
 CONFIG_A=y
 # CONFIG_B is not set
 CONFIG_D=y
 CONFIG_E=y

emits a spurious warning:

(D) selects E which has unmet direct dependencies (B)

If a symbol appears in two different branch of the tree, it should inherit the
dependency of both parent, not just the last one.

Reported-by: Yann E. Morin <yann.morin.1998@anciens.enib.fr>
Tested-by: Yann E. Morin <yann.morin.1998@anciens.enib.fr>
Signed-off-by: Arnaud Lacombe <lacombar@gmail.com>
Signed-off-by: Michal Marek <mmarek@suse.cz>
scripts/kconfig/menu.c