fuse: fix use-after-free in fuse_direct_IO()
authorLukas Czerner <lczerner@redhat.com>
Fri, 9 Nov 2018 13:51:46 +0000 (14:51 +0100)
committerMiklos Szeredi <mszeredi@redhat.com>
Fri, 9 Nov 2018 14:52:17 +0000 (15:52 +0100)
commitebacb81273599555a7a19f7754a1451206a5fc4f
treedd4ec65102426360a2b5b89552885f318ac5d302
parent2d84a2d19b6150c6dbac1e6ebad9c82e4c123772
fuse: fix use-after-free in fuse_direct_IO()

In async IO blocking case the additional reference to the io is taken for
it to survive fuse_aio_complete(). In non blocking case this additional
reference is not needed, however we still reference io to figure out
whether to wait for completion or not. This is wrong and will lead to
use-after-free. Fix it by storing blocking information in separate
variable.

This was spotted by KASAN when running generic/208 fstest.

Signed-off-by: Lukas Czerner <lczerner@redhat.com>
Reported-by: Zorro Lang <zlang@redhat.com>
Signed-off-by: Miklos Szeredi <mszeredi@redhat.com>
Fixes: 744742d692e3 ("fuse: Add reference counting for fuse_io_priv")
Cc: <stable@vger.kernel.org> # v4.6
fs/fuse/file.c