scsi: cxgbi: remove redundant __kfree_skb call on skb and free cst->atid
authorColin Ian King <colin.king@canonical.com>
Fri, 12 Apr 2019 08:33:01 +0000 (09:33 +0100)
committerMartin K. Petersen <martin.petersen@oracle.com>
Sat, 13 Apr 2019 00:05:31 +0000 (20:05 -0400)
commitea63e60f7a3e9fd494b46d1c68d3d26b068c2d63
tree08bedb940f787b3024c988b7d69e3953e0a2cae7
parentc8538b0b9ed65eb22849217fd397d614a42216e7
scsi: cxgbi: remove redundant __kfree_skb call on skb and free cst->atid

The error return path via label rel_resource checks for a non-null skb
before free'ing it.  However, skb is always null at this exit path, so the
null check and the free are redundant and can be removed.  Removing this
allows the original goto's to rel_resource to be cleaned up; the first can
be replaced by a return of -EINVAL, the second can be replaced by a more
appropriate -ENOMEM return and fix a memory leak by freeing csk->atid.

Addresses-Coverity: ("Logically Dead Code")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/cxgbi/cxgb3i/cxgb3i.c