x86/apic: Fix integer overflow on 10 bit left shift of cpu_khz
authorColin Ian King <colin.king@canonical.com>
Wed, 19 Jun 2019 18:14:46 +0000 (19:14 +0100)
committerThomas Gleixner <tglx@linutronix.de>
Sat, 22 Jun 2019 09:59:31 +0000 (11:59 +0200)
commitea136a112d89bade596314a1ae49f748902f4727
treeaaf91cd28e72da9cbaaf5bef2f9cf28e5ee72b56
parent32f010deab575199df4ebe7b6aec20c17bb7eccd
x86/apic: Fix integer overflow on 10 bit left shift of cpu_khz

The left shift of unsigned int cpu_khz will overflow for large values of
cpu_khz, so cast it to a long long before shifting it to avoid overvlow.
For example, this can happen when cpu_khz is 4194305, i.e. ~4.2 GHz.

Addresses-Coverity: ("Unintentional integer overflow")
Fixes: 8c3ba8d04924 ("x86, apic: ack all pending irqs when crashed/on kexec")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: Borislav Petkov <bp@alien8.de>
Cc: "H . Peter Anvin" <hpa@zytor.com>
Cc: kernel-janitors@vger.kernel.org
Link: https://lkml.kernel.org/r/20190619181446.13635-1-colin.king@canonical.com
arch/x86/kernel/apic/apic.c