sh/mmiowb: Add unconditional mmiowb() to arch_spin_unlock()
authorWill Deacon <will.deacon@arm.com>
Fri, 22 Feb 2019 13:37:21 +0000 (13:37 +0000)
committerWill Deacon <will.deacon@arm.com>
Mon, 8 Apr 2019 11:00:21 +0000 (12:00 +0100)
commite9e8543fecd2e1ca53616ba82fbd55a25cd2ab8a
treea6139b9501c2b950c997f83273fcb5936c77dd2b
parent0f43ca692dcb55108ea9a59c11a1a0e359dba367
sh/mmiowb: Add unconditional mmiowb() to arch_spin_unlock()

The mmiowb() macro is horribly difficult to use and drivers will continue
to work most of the time if they omit a call when it is required.

Rather than rely on driver authors getting this right, push mmiowb() into
arch_spin_unlock() for sh. If this is deemed to be a performance issue,
a subsequent optimisation could make use of ARCH_HAS_MMIOWB to elide
the barrier in cases where no I/O writes were performed inside the
critical section.

Cc: Yoshinori Sato <ysato@users.sourceforge.jp>
Cc: Rich Felker <dalias@libc.org>
Acked-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Will Deacon <will.deacon@arm.com>
arch/sh/include/asm/Kbuild
arch/sh/include/asm/io.h
arch/sh/include/asm/mmiowb.h [new file with mode: 0644]
arch/sh/include/asm/spinlock-llsc.h