libceph: fix alloc_msg_with_page_vector() memory leaks
authorIlya Dryomov <idryomov@gmail.com>
Tue, 10 Mar 2020 15:19:01 +0000 (16:19 +0100)
committerIlya Dryomov <idryomov@gmail.com>
Mon, 23 Mar 2020 12:07:08 +0000 (13:07 +0100)
commite886274031200bb60965c1b9c49b7acda56a93bd
tree560b5590c7de6177f776bda600e934c253740ee5
parent7614209736fbc4927584d4387faade4f31444fce
libceph: fix alloc_msg_with_page_vector() memory leaks

Make it so that CEPH_MSG_DATA_PAGES data item can own pages,
fixing a bunch of memory leaks for a page vector allocated in
alloc_msg_with_page_vector().  Currently, only watch-notify
messages trigger this allocation, and normally the page vector
is freed either in handle_watch_notify() or by the caller of
ceph_osdc_notify().  But if the message is freed before that
(e.g. if the session faults while reading in the message or
if the notify is stale), we leak the page vector.

This was supposed to be fixed by switching to a message-owned
pagelist, but that never happened.

Fixes: 1907920324f1 ("libceph: support for sending notifies")
Reported-by: Roman Penyaev <rpenyaev@suse.de>
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
Reviewed-by: Roman Penyaev <rpenyaev@suse.de>
include/linux/ceph/messenger.h
net/ceph/messenger.c
net/ceph/osd_client.c