ASoC: soc-pcm: don't use bit-OR'ed error
authorKuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Mon, 10 Feb 2020 03:14:26 +0000 (12:14 +0900)
committerMark Brown <broonie@kernel.org>
Tue, 11 Feb 2020 15:41:44 +0000 (15:41 +0000)
commite82ebffce3ec07584bcc2fc4c4d33a43fd9515f5
tree25c29da61a30115d67a4d4f6d6f53a71eb3fbade
parent09e88f8a5c56ac5258935a5a543868c20a55d4dd
ASoC: soc-pcm: don't use bit-OR'ed error

Current soc-pcm is using bit-OR'ed error

ret |= snd_soc_component_close(component, substream);
ret |= snd_soc_component_hw_free(component, substream);

The driver may return arbitrary error codes so they can conflict.
The bit-OR'ed error works only if the return code is always consistent.
This patch fixup it, and use *last* ret value.

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Link: https://lore.kernel.org/r/877e0vceyc.wl-kuninori.morimoto.gx@renesas.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/soc-pcm.c