can: can_dropped_invalid_skb(): ensure an initialized headroom in outgoing CAN sk_buffs
authorOliver Hartkopp <socketcan@hartkopp.net>
Sat, 7 Dec 2019 18:34:18 +0000 (19:34 +0100)
committerMarc Kleine-Budde <mkl@pengutronix.de>
Thu, 2 Jan 2020 14:34:27 +0000 (15:34 +0100)
commite7153bf70c3496bac00e7e4f395bb8d8394ac0ea
tree916e307b02f8f88d6db4ce4878104be0f4cd31f4
parent93bdc0eb0b4bb5e7094fd4a95f4a394e4a927e09
can: can_dropped_invalid_skb(): ensure an initialized headroom in outgoing CAN sk_buffs

KMSAN sysbot detected a read access to an untinitialized value in the
headroom of an outgoing CAN related sk_buff. When using CAN sockets this
area is filled appropriately - but when using a packet socket this
initialization is missing.

The problematic read access occurs in the CAN receive path which can
only be triggered when the sk_buff is sent through a (virtual) CAN
interface. So we check in the sending path whether we need to perform
the missing initializations.

Fixes: d3b58c47d330d ("can: replace timestamp as unique skb attribute")
Reported-by: syzbot+b02ff0707a97e4e79ebb@syzkaller.appspotmail.com
Signed-off-by: Oliver Hartkopp <socketcan@hartkopp.net>
Tested-by: Oliver Hartkopp <socketcan@hartkopp.net>
Cc: linux-stable <stable@vger.kernel.org> # >= v4.1
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
include/linux/can/dev.h