cpufreq: Add NULL checks to show() and store() methods of cpufreq
authorKai Shen <shenkai8@huawei.com>
Thu, 7 Nov 2019 05:08:17 +0000 (05:08 +0000)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Fri, 8 Nov 2019 10:49:15 +0000 (11:49 +0100)
commite6e8df07268c1f75dd9215536e2ce4587b70f977
treee175fbffe87247ea20ffee6fb4e32912f7d939ff
parent8d2eecead5bf23865cb73062a4e7139a9dbce5a1
cpufreq: Add NULL checks to show() and store() methods of cpufreq

Add NULL checks to show() and store() in cpufreq.c to avoid attempts
to invoke a NULL callback.

Though some interfaces of cpufreq are set as read-only, users can
still get write permission using chmod which can lead to a kernel
crash, as follows:

chmod +w /sys/devices/system/cpu/cpu0/cpufreq/scaling_cur_freq
echo 1 >  /sys/devices/system/cpu/cpu0/cpufreq/scaling_cur_freq

This bug was found in linux 4.19.

Signed-off-by: Kai Shen <shenkai8@huawei.com>
Reported-by: Feilong Lin <linfeilong@huawei.com>
Reviewed-by: Feilong Lin <linfeilong@huawei.com>
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
[ rjw: Subject & changelog ]
Cc: All applicable <stable@vger.kernel.org>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
drivers/cpufreq/cpufreq.c