can: kvaser_usb: Fix state handling upon BUS_ERROR events
authorAhmed S. Darwish <ahmed.darwish@valeo.com>
Mon, 26 Jan 2015 05:25:43 +0000 (07:25 +0200)
committerMarc Kleine-Budde <mkl@pengutronix.de>
Tue, 27 Jan 2015 07:55:09 +0000 (08:55 +0100)
commite638642b08c170d2021b706f0b1c4f4ae93d8cbd
tree06fc61fd8ee8e6c320606f545bbc1eba8f7078ab
parent14c10c2a1dd8eb8e00b750b521753260befa2789
can: kvaser_usb: Fix state handling upon BUS_ERROR events

While being in an ERROR_WARNING state, and receiving further
bus error events with error counters still in the ERROR_WARNING
range of 97-127 inclusive, the state handling code erroneously
reverts back to ERROR_ACTIVE.

Per the CAN standard, only revert to ERROR_ACTIVE when the
error counters are less than 96.

Moreover, in certain Kvaser models, the BUS_ERROR flag is
always set along with undefined bits in the M16C status
register. Thus use bitwise operators instead of full equality
for checking that register against bus errors.

Signed-off-by: Ahmed S. Darwish <ahmed.darwish@valeo.com>
Cc: linux-stable <stable@vger.kernel.org>
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
drivers/net/can/usb/kvaser_usb.c