virtio-net: disable guest csum during XDP set
authorJason Wang <jasowang@redhat.com>
Thu, 22 Nov 2018 06:36:30 +0000 (14:36 +0800)
committerDavid S. Miller <davem@davemloft.net>
Fri, 23 Nov 2018 19:59:40 +0000 (11:59 -0800)
commite59ff2c49ae16e1d179de679aca81405829aee6c
treed0da9016181e1806fc2efcca0c0a3b89c2fa9c1e
parent484afd1bd3fc6f9f5347289fc8b285aa65f67054
virtio-net: disable guest csum during XDP set

We don't disable VIRTIO_NET_F_GUEST_CSUM if XDP was set. This means we
can receive partial csumed packets with metadata kept in the
vnet_hdr. This may have several side effects:

- It could be overridden by header adjustment, thus is might be not
  correct after XDP processing.
- There's no way to pass such metadata information through
  XDP_REDIRECT to another driver.
- XDP does not support checksum offload right now.

So simply disable guest csum if possible in this the case of XDP.

Fixes: 3f93522ffab2d ("virtio-net: switch off offloads on demand if possible on XDP set")
Reported-by: Jesper Dangaard Brouer <brouer@redhat.com>
Cc: Jesper Dangaard Brouer <brouer@redhat.com>
Cc: Pavel Popa <pashinho1990@gmail.com>
Cc: David Ahern <dsahern@gmail.com>
Signed-off-by: Jason Wang <jasowang@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/virtio_net.c