tcp: identify cryptic messages as TCP seq # bugs
authorRandy Dunlap <rdunlap@infradead.org>
Wed, 18 Jul 2018 01:27:45 +0000 (18:27 -0700)
committerDavid S. Miller <davem@davemloft.net>
Wed, 18 Jul 2018 22:26:33 +0000 (15:26 -0700)
commite56b8ce363a36fb7b74b80aaa5cc9084f2c908b4
treead9b631bcfcf48e2e979b747544d7ac153e3bd19
parent9ba8376ce1e2cbf4ce44f7e4bee1d0648e10d594
tcp: identify cryptic messages as TCP seq # bugs

Attempt to make cryptic TCP seq number error messages clearer by
(1) identifying the source of the message as "TCP", (2) identifying the
errors as "seq # bug", and (3) grouping the field identifiers and values
by separating them with commas.

E.g., the following message is changed from:

recvmsg bug 2: copied 73BCB6CD seq 70F17CBE rcvnxt 73BCB9AA fl 0
WARNING: CPU: 2 PID: 1501 at /linux/net/ipv4/tcp.c:1881 tcp_recvmsg+0x649/0xb90

to:

TCP recvmsg seq # bug 2: copied 73BCB6CD, seq 70F17CBE, rcvnxt 73BCB9AA, fl 0
WARNING: CPU: 2 PID: 1501 at /linux/net/ipv4/tcp.c:2011 tcp_recvmsg+0x694/0xba0

Suggested-by: 積丹尼 Dan Jacobson <jidanni@jidanni.org>
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Signed-off-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv4/tcp.c