netfilter: x_tables: don't return garbage pointer on modprobe failure
authorFlorian Westphal <fw@strlen.de>
Sat, 13 Jan 2018 13:06:08 +0000 (14:06 +0100)
committerPablo Neira Ayuso <pablo@netfilter.org>
Tue, 16 Jan 2018 00:51:59 +0000 (01:51 +0100)
commite3eeacbac4ad34fac93f82a7cf15402bba83d22e
tree2869ff48cca83aee6deee69c1bbdc21cf5a8a2cf
parent9be9d04b28e75b52f83e3e10ee529a1ec992a2c0
netfilter: x_tables: don't return garbage pointer on modprobe failure

request_module may return a positive error result from modprobe,
if we cast this to ERR_PTR this returns a garbage result (it passes
IS_ERR checks).

Fix it by ignoring modprobe return values entirely, just retry the
table lookup instead.

Reported-by: syzbot+980925dbfbc7f93bc2ef@syzkaller.appspotmail.com
Fixes: 03d13b6868a2 ("netfilter: xtables: add and use xt_request_find_table_lock")
Fixes: 20651cefd25f ("netfilter: x_tables: unbreak module auto loading")
Signed-off-by: Florian Westphal <fw@strlen.de>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
net/netfilter/x_tables.c